Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Outputs maps in RESS #20

Merged
merged 4 commits into from
Nov 12, 2020
Merged

[ENH] Outputs maps in RESS #20

merged 4 commits into from
Nov 12, 2020

Conversation

nbara
Copy link
Owner

@nbara nbara commented Nov 10, 2020

Fixes #19

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #20 (b452968) into master (3d70356) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   71.96%   72.03%   +0.07%     
==========================================
  Files          16       16              
  Lines        1869     1874       +5     
==========================================
+ Hits         1345     1350       +5     
  Misses        524      524              
Impacted Files Coverage Δ
meegkit/ress.py 100.00% <100.00%> (ø)
meegkit/utils/__init__.py 100.00% <100.00%> (ø)
meegkit/utils/matrix.py 83.15% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d70356...b452968. Read the comment docs.

@nbara nbara merged commit a7d98ea into master Nov 12, 2020
@nbara nbara deleted the nb/fix-issue-19 branch February 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RESS output shape appears to be (samples, trials) instead of (samples, channels, trials)
1 participant