Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] RESS: removed hardcoded values #22

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

paulroujansky
Copy link
Contributor

@paulroujansky paulroujansky commented Nov 17, 2020

Description

  • Replaced hardcoded value for fwhm when computing left covariance of noise
  • Added peak_width to set fwhm when computing signal covariance (from Mike X Cohen)
  • Enhanced test

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #22 (a7a66f0) into master (1e8c7cf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   74.53%   74.53%           
=======================================
  Files          18       18           
  Lines        2054     2054           
=======================================
  Hits         1531     1531           
  Misses        523      523           
Impacted Files Coverage Δ
meegkit/utils/stats.py 39.71% <ø> (ø)
meegkit/ress.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e8c7cf...a7a66f0. Read the comment docs.

@nbara nbara merged commit 4f65c68 into nbara:master Nov 24, 2020
@nbara nbara added the enhancement New feature or request label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants