Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Detrending error with high-order polynomials #36

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

nbara
Copy link
Owner

@nbara nbara commented Apr 7, 2021

There was a bug when using a multi-dimensional regressor in detrend()

@nbara nbara added the bug Something isn't working label Apr 7, 2021
@nbara nbara self-assigned this Apr 7, 2021
@nbara nbara linked an issue Apr 7, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #36 (999d94f) into master (35d79f3) will increase coverage by 1.32%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   75.75%   77.08%   +1.32%     
==========================================
  Files          18       18              
  Lines        2058     2055       -3     
==========================================
+ Hits         1559     1584      +25     
+ Misses        499      471      -28     
Impacted Files Coverage Δ
meegkit/detrend.py 90.37% <92.30%> (+20.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d79f3...999d94f. Read the comment docs.

@nbara nbara merged commit cee6af6 into master Apr 7, 2021
@nbara nbara deleted the nb/fix-issue-34 branch April 7, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dimension error when detrending with higher order polynomial
1 participant