Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Null channels cause dss.dss0 to crash #4

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

paulroujansky
Copy link
Contributor

Description

When the values of n_chans - 1 channels are set to zero, dss.dss0() returns a ValueError: expected square matrix message. This is because the passed input matrix c2 is one-dimensional (because it has 1 feature only, corresponding to the not-null channel).

Proposed fix is to leave it 2-dimensional by removing squeeze().

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   67.30%   67.30%           
=======================================
  Files          14       14           
  Lines        1838     1838           
=======================================
  Hits         1237     1237           
  Misses        601      601           
Impacted Files Coverage Δ
meegkit/dss.py 76.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485f8be...b656479. Read the comment docs.

@nbara nbara merged commit 1ce30b7 into nbara:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants