Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] make dss_line() faster #57

Merged
merged 5 commits into from
Dec 2, 2021
Merged

[ENH] make dss_line() faster #57

merged 5 commits into from
Dec 2, 2021

Conversation

nbara
Copy link
Owner

@nbara nbara commented Dec 1, 2021

  • add blocksize parameter to dss_line()
  • matmul3d works with 2d data

@nbara
[ENH] make dss_line() faster
e64eca8 
- add blocksize parameter to dss_line()
- matmul3d works with 2d data
@nbara nbara added the enhancement New feature or request label Dec 1, 2021
@nbara nbara self-assigned this Dec 1, 2021
This was referenced Dec 1, 2021
Open
Closed
@nbara nbara changed the title [ENH] make dss_line() faster [ENH] make dss_line() faster Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021 •
edited

Codecov Report

Merging #57 (216fffc) into master (7f8192a) will decrease coverage by 0.01%.
The diff coverage is 94.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   78.75%   78.73%   -0.02%     
==========================================
  Files          21       21              
  Lines        2306     2314       +8     
==========================================
+ Hits         1816     1822       +6     
- Misses        490      492       +2
Impacted Files Coverage Δ
meegkit/utils/__init__.py 100.00% <ø> (ø)
meegkit/utils/matrix.py 82.69% <80.00%> (-0.46%) ⬇️
meegkit/dss.py 90.20% <96.15%> (+0.28%) ⬆️
meegkit/detrend.py 90.27% <100.00%> (+0.13%) ⬆️
meegkit/tspca.py 64.38% <100.00%> (-0.49%) ⬇️
meegkit/utils/denoise.py 76.00% <100.00%> (+0.19%) ⬆️
meegkit/utils/sig.py 57.83% <100.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8192a...216fffc. Read the comment docs.

@eort eort mentioned this pull request Dec 2, 2021
Merged
eort and others added 2 commits December 2, 2021 18:06
@eort @nbara
Reduce memory footprint of dss_line (#58)
257bb9d 
* memsaving suggestions

* remove testing code

* fix pep and flake

* undo matrix change

* undo matrix reshaping

* compromise

Co-authored-by: nbara <10333715+nbara@users.noreply.github.com>
@nbara
doc
216fffc
@nbara nbara merged commit af5acae into master Dec 2, 2021
@nbara nbara linked an issue Dec 2, 2021 that may be closed by this pull request
ZapLine improvements #50
Open
4 tasks
@nbara nbara deleted the nb/fastline branch May 9, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nbara nbara

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZapLine improvements
2 participants
@nbara @eort