Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add a bad channel detection method using LOF algorithm #66

Merged
merged 9 commits into from
May 9, 2023

Conversation

vpKumaravel
Copy link
Contributor

Reference issue
NA

What does this implement/fix?
This PR contains a new feature for bad channel detection using Local Outlier Factor (LOF) algorithm.
File name: lof.py
To be compliant, I also added the test_lof.py file along with the test data lofdata.mat

Additional information
The proposed algorithm is used in Newborns EEG Artifact Removal (NEAR) pipeline published earlier this year. Recently, we analyzed data from adult subjects and the algorithm is adaptable to different populations.

Best regards,
Velu

@nbara nbara added the enhancement New feature or request label May 5, 2023
@nbara nbara changed the title adding a bad channel detection method using LOF algorithm [ENH] Add a bad channel detection method using LOF algorithm May 5, 2023
@nbara
Copy link
Owner

nbara commented May 5, 2023

Hey @vpKumaravel, thanks! Will have a look as soon as possible. In the meantime, I activated the CI which where disabled for some reason. Best, Nicolas

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #66 (3e53949) into master (5e95ee5) will increase coverage by 0.03%.
The diff coverage is 84.00%.

❗ Current head 3e53949 differs from pull request most recent head c7a89eb. Consider uploading reports for the commit c7a89eb to get more accurate results

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   78.74%   78.78%   +0.03%     
==========================================
  Files          21       22       +1     
  Lines        2315     2338      +23     
==========================================
+ Hits         1823     1842      +19     
- Misses        492      496       +4     
Impacted Files Coverage Δ
meegkit/lof.py 82.60% <82.60%> (ø)
meegkit/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@nbara nbara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vpKumaravel This is perfect, thanks!

@nbara nbara merged commit 30de2e7 into nbara:master May 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants