Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] dss_line() with nremove>1 #9

Merged
merged 1 commit into from
Sep 10, 2020
Merged

[FIX] dss_line() with nremove>1 #9

merged 1 commit into from
Sep 10, 2020

Conversation

nbara
Copy link
Owner

@nbara nbara commented Sep 8, 2020

This is an attempt to fix #8

There was a bug in one of the utility functions. dss_line() should now also be more robust to 3D data.

@nbara nbara self-assigned this Sep 8, 2020
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   67.30%   67.64%   +0.34%     
==========================================
  Files          14       14              
  Lines        1838     1842       +4     
==========================================
+ Hits         1237     1246       +9     
+ Misses        601      596       -5     
Impacted Files Coverage Δ
meegkit/dss.py 77.77% <100.00%> (+1.65%) ⬆️
meegkit/tspca.py 64.86% <100.00%> (+4.33%) ⬆️
meegkit/utils/matrix.py 83.62% <100.00%> (+0.23%) ⬆️
meegkit/utils/sig.py 44.73% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10e7f9...91d9a3b. Read the comment docs.

@nbara nbara changed the title [FIX] dss_line() works with nremove>1 [FIX] dss_line() with nremove>1 Sep 8, 2020
@nbara nbara merged commit c6c5e5e into master Sep 10, 2020
@nbara nbara deleted the nb/fix-issue-8 branch February 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applying ZapLine to continuous data
1 participant