Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saveAsBuffer() returns a Uint8Array instead of a Buffer #93

Closed
t0m4-null opened this issue Aug 26, 2022 · 1 comment · Fixed by #94
Closed

saveAsBuffer() returns a Uint8Array instead of a Buffer #93

t0m4-null opened this issue Aug 26, 2022 · 1 comment · Fixed by #94
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@t0m4-null
Copy link

Since v4.0.0 (and pdf-lib replacing pdfjs), saveAsBuffer() method returns a Uint8Array instead of a Buffer.

So, to fix it, I had to replace await merger.saveAsBuffer() with Buffer.from(await merger.saveAsBuffer())
@mojoaxel mojoaxel added bug Something isn't working good first issue Good for newcomers labels Aug 26, 2022
@mojoaxel
Copy link
Collaborator

@t0m4-null Yeah, that is a bug, introduced by #84

I'll provide a fix, soon.

mojoaxel added a commit that referenced this issue Aug 26, 2022
@mojoaxel
fix(#93): saveAsBuffer should return a Buffer
71df5ba
@mojoaxel mojoaxel mentioned this issue Aug 26, 2022
Merged
mojoaxel added a commit that referenced this issue Aug 26, 2022
@mojoaxel
fix(#93): saveAsBuffer should return a Buffer
d133bc3
mojoaxel added a commit that referenced this issue Aug 26, 2022
@mojoaxel
fix(#93): saveAsBuffer should return a Buffer
cdc49ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#93): saveAsBuffer should return a Buffer nbesli/pdf-merger-js
2 participants
@mojoaxel @t0m4-null