Add default temperature thresholds #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool to convert nbfc configs to json just left empty arrays for temperature thresholds. This PR fixes this by replacing thresholds with default values if they are empty in the config. The defaults are taken from default values in original nbfc. I've also run the tool against the original nbfc tool to update the configs.
samuaz
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool to convert nbfc configs to json just left empty arrays for
temperature thresholds.
This PR fixes this by replacing thresholds with default values if
they are empty in the config. The defaults are taken from default
values in original nbfc.
I've also run the tool against the original nbfc tool to update the
configs.