Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export ndarray #45

Merged
merged 2 commits into from
Dec 26, 2020
Merged

Re-export ndarray #45

merged 2 commits into from
Dec 26, 2020

Conversation

nbigaouette
Copy link
Owner

Since the public API depends on ndarray, downstream user need to add it in their Cargo.toml.

This re-export allows downstream user not to add the dependency in their Cargo.toml.

Closes #44.

@codecov-io
Copy link

Codecov Report

Merging #45 (0cadee1) into master (4a02bc0) will decrease coverage by 5.04%.
The diff coverage is 23.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   19.18%   14.13%   -5.05%     
==========================================
  Files          17       18       +1     
  Lines         610      962     +352     
==========================================
+ Hits          117      136      +19     
- Misses        493      826     +333     
Impacted Files Coverage Δ
...runtime-sys/src/generated/macos/x86_64/bindings.rs 0.00% <ø> (ø)
onnxruntime/src/session.rs 0.00% <0.00%> (ø)
onnxruntime/src/lib.rs 32.53% <41.02%> (+7.53%) ⬆️
onnxruntime/src/environment.rs 89.83% <100.00%> (+8.47%) ⬆️
onnxruntime/src/memory.rs 93.33% <100.00%> (ø)
onnxruntime/src/tensor/ort_tensor.rs 82.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24b4cd...0cadee1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should ndarray types be re-exported?
2 participants