Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHy can't we use biopython > 1.67 h #24

Closed
tseemann opened this issue Aug 22, 2018 · 9 comments · Fixed by #47
Closed

WHy can't we use biopython > 1.67 h #24

tseemann opened this issue Aug 22, 2018 · 9 comments · Fixed by #47

Comments

@tseemann
Copy link

emblmygff3 1.2.3 has requirement biopython==1.67, but you'll have biopython 1.72 which is incompatible.
@Juke34
Copy link
Collaborator

Juke34 commented Aug 22, 2018

At the time we started the project it was biopython 1.67. When a new version came out we realised there was an incompatibility due to the fact they have deprecated and removed sub_features.
We should update the code to make it working with version >= 1.68.

@hinz1
Copy link

hinz1 commented Oct 16, 2019

Exactly 1.67? So I would have to downgrade my system to run your tool?

@Juke34
Copy link
Collaborator

Juke34 commented Oct 16, 2019

You could give a try to version >1.68. If it works we can just exclude version 1.68.
If it doesn't work don't downgrade your system, use Conda instead.

@tseemann
Copy link
Author

tseemann commented Oct 16, 2019

I agree conda envs are a solution to this, but 25 August 2016: Biopython 1.68 is >3 years old now. Who knows what other bugs have been fixed?

@Juke34
Copy link
Collaborator

Juke34 commented Oct 17, 2019

I agree. For our defence we use it just a little, few core methods so it guess it should not be any big difference even after many years.
We can probably use more recent version but we haven't try. I will put it in my to do list.
Anyway with the version 2 (branch feature/speedup) we should overcome this limitation.

@hinz1
Copy link

hinz1 commented Oct 17, 2019

Well, we got by by installing on a machine that was rather "clean", python-wise, so installation went through and everything worked. So, thank you for publishing your work. I'll keep in mind that conda would be another way. As much as I like Python as a language, the ecosystem really is a mess. ;)

@tseemann
Copy link
Author

What is the ETA for version 2?

@Juke34
Copy link
Collaborator

Juke34 commented Oct 18, 2019

Early 2019 :). We have re-developed the core of the tool to make it faster and add parallelisation, but since then we haven't had time to implement and test the numerous parameters we have in version 1.
Btw I have look into detail about the issue with Biopython version >1.67, and seems finally really easy to fix. I will push a fix soon.

Juke34 added a commit that referenced this issue Oct 18, 2019
Juke34 added a commit that referenced this issue Oct 18, 2019
…-gff>0.6.4. Specify numpy<1.16.5 in install_requires because it is the last version compatible with python 2.7
@Juke34 Juke34 mentioned this issue Oct 18, 2019
@tseemann
Copy link
Author

Thanks @Juke34 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants