WIP: Added Azure Build Pipeline configuration #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are there commits in this PR that are already in master? can you rebase please? |
Broken by 516a3c4c2cbae0f90a9e42bc84565cb47522f8bb oops!
* Instead of InvalidOperationException, use FormatException. * Instead of throwing generic (and not catchable)System.Exception, throw a new typed Rpc-prefixed exception. This is so that Nethereum consumers can catch faulty responses from buggy servers, like demonstrated in: Nethereum/Nethereum#380 (comment)
* Moved to ClientBase all inner request implementations, historically there was a separtation due to the dependency of RPC to EdjCase.JsonRPC.Core. * Ipc / UnixSockets / websockets now use @knocte 's new RPCFormatException (all use the same class) * Ensure everything uses ConfigureAwait (false)
When thinking of contributing a new Nethereum.JsonRpc client type (the TCP one) to Nethereum, I thought: "but wait a second, the result of this would be a library that I will actually use to talk to Electrum servers!" (which means: nothing related to Ethereum at all), so I thought: "Nethereum.JsonRpc should probably live as a general-purpose library in the .NET world, no need to mark it as 'Ethereum' related". So this subproject was born. I extracted @juanfranblanco's libs into this new JsonRpcSharp proof of concept, leaving git history intact (via `git clean -fdx && git tag | xargs git tag -d && git filter-branch --index-filter 'git rm --cached -qr --ignore-unmatch -- . && git reset -q $GIT_COMMIT -- src/Nethereum.JsonRpc.Client src/Nethereum.JsonRpc.IpcClient src/Nethereum.JsonRpc.RpcClient src/Nethereum.JsonRpc.WebSocketClient src/Nethereum.JsonRpc.UnixIpcClient lib' --prune-empty -- --all`). After that, replaced any text occurrence of Nethereum.JsonRpc with JsonRpcSharp (even in filenames and dirnames), and NethereumVersion with JsonRpcSharpVersion, and deleted any ethereum occurrences.
|
Replaced by #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.