More fee rate sources #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just extract some functions to be able to reuse later.
Historically, electrum servers return really shitty (as in, too expensive) fee rates, so we mitigate this problem by querying mempool.space API too and calculate the average.
Rather than just having electrumservers and mempool.space API, let's have a third source of truth.
knocte
added a commit
that referenced
this pull request
May 19, 2024
While working on the unit tests for PR 278 [1], I noticed that when I implemented this function in the stable branch to calculate the average between 3 values discarding the outlier, I missed the edge case when the distance between the highest and the lowest is the same. So, in this case, let's discard the intermediate (the intermediate will in the end be the average, but that is calculated later in the code). [1] #278
Fee rate estimation in geewallet has always aimed to be high because we've always aimed to focus on finishing L2 support, so for channels to be opened/closed we wanted fast conf times. However, LN development is taking a bit long, and we're now sometimes facing periods of high-fee environments, so it's interesting to start working on this feature. Right now, this refactoring introduces two kinds of priority but the UX towards the user doesn't change because the wallet is still configured to choose the highest. This just lays the groundwork for a future feature.
knocte
force-pushed
the
wip/moreFeeRateSources
branch
from
8442358
to
f762410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272