Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for white-spaces in target #8

Merged
merged 1 commit into from Feb 22, 2022
Merged

Added support for white-spaces in target #8

merged 1 commit into from Feb 22, 2022

Conversation

DobroAlex
Copy link

@DobroAlex DobroAlex commented Feb 22, 2022

It might have something to do with the fact that I run on WSL2 (or me being stupid). However, if the target directory for searching contains whitespace (no matter if they are escaped using "/some path/dir" or /some \path/dir" it causes errors.

Examples:

  • Without this patch:

    • Sample 1
      Input:
      /c/Users/User/source/php-malware-finder/php-malware-finder/phpmalwarefinder -c "/c/Users/User/source/php-malware-finder/php-malware-finder/php.yar" -t 4 ~/white\ space\ test/php_malware_finder/test_1/
      Output:
      error: could not open file: /home/alex/white
    • Sample 2
      Input:
      /c/Users/User/source/php-malware-finder/php-malware-finder/phpmalwarefinder -c "/c/Users/User/source/php-malware-finder/php-malware-finder/php.yar" -t 4 "white space test/php_malware_finder/test_1"
      Output:
      error: could not open file: white
  • With this patch:

    • Sample 1
      Input:
      /c/Users/User/source/php-malware-finder/php-malware-finder/phpmalwarefinder -c "/c/Users/User/source/php-malware-finder/php-malware-finder/php.yar" -t 4 ~/white\ space\ test/php_malware_finder/test_1/
      Output (as expected):
      DodgyPhp /home/alex/white space test/php_malware_finder/test_1/aboba.php
      ObfuscatedPhp /home/alex/white space test/php_malware_finder/test_1/SendMonthlyTaskListCompletionReminder.php
    • Sample 2:
      Input:
      /c/Users/User/source/php-malware-finder/php-malware-finder/phpmalwarefinder -c "/c/Users/User/source/php-malware-finder/php-malware-finder/php.yar" -t 4 "white space test/php_malware_finder/test_1"
      Output (as expected):
      DodgyPhp /home/alex/white space test/php_malware_finder/test_1/aboba.php
      ObfuscatedPhp /home/alex/white space test/php_malware_finder/test_1/SendMonthlyTaskListCompletionReminder.php

@wargio wargio merged commit b8698eb into nbs-system:master Feb 22, 2022
jvoisin pushed a commit to jvoisin/php-malware-finder that referenced this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants