Add a test for unmatched brackets

nbs-system · Oct 23, 2017 · ca51803 · ca51803
1 parent 2c42514
commit ca51803
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/sp_config_utils.c b/src/sp_config_utils.c
@@ -2,9 +2,7 @@
 
 size_t sp_line_no;
 
-static int validate_str(const char *value);
-
-static sp_pure int validate_str(const char *value) {
+static int validate_str(const char *value) {
   int balance = 0;  // ghetto [] validation
 
   if (!strchr(value, '[')) {
@@ -18,6 +16,7 @@ static sp_pure int validate_str(const char *value) {
       balance--;
     }
     if (balance < 0) {
+      sp_log_err("config", "The string '%s' contains unbalanced brackets.", value);
       return -1;
     }
   }

diff --git a/src/tests/broken_unmatching_brackets.phpt b/src/tests/broken_unmatching_brackets.phpt
@@ -0,0 +1,9 @@
+--TEST--
+Broken configuration - unmatching brackets
+--SKIPIF--
+<?php if (!extension_loaded("snuffleupagus")) die "skip"; ?>
+--INI--
+sp.configuration_file={PWD}/config/config_unmatching_brackets.ini
+--FILE--
+--EXPECTF--
+[snuffleupagus][0.0.0.0][config][error] The string 'arr[b]]]]]' contains unbalanced brackets.
diff --git a/src/tests/config/config_unmatching_brackets.ini b/src/tests/config/config_unmatching_brackets.ini
@@ -0,0 +1 @@
+sp.disable_function.function("foo").param("arr[b]]]]]").value("aaa").alias("4").drop();