Extract handle_missing_response!
#25
Conversation
| def handle_missing_response! | ||
| logger.debug("Delegate authentication to Rack::OpenID by throwing a 401") | ||
|
|
||
| opts = { identifier: identity_url, return_to: return_url, trust_root: trust_root, method: 'post' } |
There was a problem hiding this comment.
I have taken the liberty of converting this hash to 1.9 syntax
|
Looks good, thanks for the PR! |
|
The merge was really quick!, @nbudin thank you for the gem! |
|
Sure thing @ecoologic! Do you want me to make a release with this change as well? (I'm not sure what functionality it is enabling, it just seems like a nice code cleanup - but if you have projects depending on this change being released I'll be happy to cut a new version.) |
|
Right now I'm just studying the gem to use it in a rails prj. Maybe officially dropping 1.9 is a CHANGELOG worthy note. This PR is plain refactoring (except for the added debug log), it doesn't seem very urgent to me, so, this is not affecting me, I leave that to you. |
|
OK, cool, in that case I will leave the 1.9 drop for the next feature release. Thanks again for the cleanup! |
handle_response)Happy to rebase it or break it down in multiple prs if you like.