Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added donation support #8

Merged
merged 3 commits into from
May 31, 2012
Merged

Added donation support #8

merged 3 commits into from
May 31, 2012

Conversation

paulschreiber
Copy link
Contributor

You can now process donations (set :purchase_type => Google4R::Checkout::Frontend::PURCHASE_TYPE_DONATION).

@nbudin
Copy link
Owner

nbudin commented May 31, 2012

Thanks Paul, sorry for the delay in accepting this patch!

I'm going to pull it, but there's a change I'd like to make before actually releasing 1.1.2. I'd rather not use Modularized::Integer::CONSTANTS for the purchase type - in my view, this is non-idiomatic Ruby and more typically something you'd see in, e.g., a Java application. I'd rather use symbols for it - we can set :purchase_type to :order or :donation, with the default setting being :order.

nbudin added a commit that referenced this pull request May 31, 2012
@nbudin nbudin merged commit 35c7faf into nbudin:master May 31, 2012
@paulschreiber
Copy link
Contributor Author

On May 31, 2012, at 4:40 PM, Nat Budin wrote:

I'm going to pull it, but there's a change I'd like to make before actually releasing 1.1.2. I'd rather not use Modularized::Integer::CONSTANTS for the purchase type - in my view, this is non-idiomatic Ruby and more typically something you'd see in, e.g., a Java application. I'd rather use symbols for it - we can set :purchase_type to :order or :donation, with the default setting being :order.

That sounds good to me.

Paul

@nbudin
Copy link
Owner

nbudin commented May 31, 2012

OK, 1.1.2 is now released! Thanks very much for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants