Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequel5 support #5

Closed
gencer opened this issue Dec 11, 2017 · 3 comments
Closed

Sequel5 support #5

gencer opened this issue Dec 11, 2017 · 3 comments
Assignees

Comments

@gencer
Copy link
Contributor

gencer commented Dec 11, 2017

Is it possible to bring Sequel v5.x support to this gem?

I manually changed gem version to 5.0 but I get an error like:
No database associated with Sequel::Model: have you called Sequel.connect or Sequel::Model.db= ? (Sequel::Error)
when generating migrations.

Just making gem to set v5 will be enough. Previous error was a mistakenly my bad :)

@nbulaj
Copy link
Owner

nbulaj commented Dec 11, 2017

Hi @gencer . So there are no problems with the Sequel5? Do I need to do smth?

@gencer
Copy link
Contributor Author

gencer commented Dec 11, 2017

@nbulaj, Only thing you have to do is increasing version in gemspec file. Currently, your gem does not installed without sequel v4. I have v5.

Here: https://github.com/nbulaj/doorkeeper-sequel/blob/master/doorkeeper-sequel.gemspec#L23

Also there is a problem with sequel+doorkeeper. Please have a look at #6.

@nbulaj
Copy link
Owner

nbulaj commented Dec 11, 2017

Fixed and merged to master, you can try it out.

@nbulaj nbulaj self-assigned this Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants