Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Score deviates from the coffee/javascript version #20

Open
freman opened this issue Apr 10, 2017 · 4 comments
Open

Score deviates from the coffee/javascript version #20

freman opened this issue Apr 10, 2017 · 4 comments

Comments

@freman
Copy link

freman commented Apr 10, 2017

./testpw Passi0n@ 'fred' 'blogs' 'johnny'
Passi0n@ [fred blogs johnny]
Score: 0

JS equiv. returns score of 1

@dtoubelis
Copy link

Facing the same issue. That golang version returns different scores then JS one. This is a problem because a password may pass validation on front end and fail at the back-end creating "what the f***" moment for a client that is impossible to justify.

@denouche
Copy link

In my case my own password give a score of 3 with JS lib, and 1 with golang library ...

@denouche
Copy link

For example 12111111AZ scores 2 using JS lib, and 0 using Golang lib ...

@vanackere
Copy link

Hi, I was also affected by this issue and after some failed attempts I came to the conclusion that this is unfortunately too difficult to achieve using the current library since the score is extremely sensitive to the way the best match sequence is found and its number of guesses is evaluated...

For those interested: I made instead a full Go port of the current coffeescript version from Dropbox, just publically available at https://github.com/trustelem/zxcvbn, that should give the exact same results as the coffeescript version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants