Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing my sign up form I noticed that some passwords meeting my strength criteria in JS were failing remotely.
It looks like the zxcvbn library currently used by authn is not conformant: nbutton23/zxcvbn-go#20
This one looks better, and at the very least passes my single test case: https://github.com/trustelem/zxcvbn and so this PR switches us over to that library.
They seem to have a reasonably good testing regime so hopefully it can be trusted. Pretty sure it is an improvement in any case.