Fix bug when listing midi devices

Was only displaying one device. Credit to Husker for finding this one! https://op-forums.com/t/op-z-tetris-for-web-browser-midi-tetris/18872/2?u=nbw
nbw · Dec 8, 2020 · 0eb3326 · 0eb3326
1 parent d350e8d
commit 0eb3326
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -298,8 +298,8 @@ const midiConnect = (target, handler) => {
   setTimeout( () => {
     if (midi.devices.length > 0) {
       const list = document.getElementById("devices");
-      const item = document.createElement('li');
       for (let i = 0; i < midi.devices.length; i++) {
+        const item = document.createElement('li');
         item.innerHTML = midi.devices[i].name;
         item.setAttribute('data-device', i);
         item.setAttribute('data-target', "5");

diff --git a/src/script.js b/src/script.js
@@ -343,9 +343,9 @@ var midiConnect = function midiConnect(target, handler) {
   setTimeout(function () {
     if (midi.devices.length > 0) {
       var list = document.getElementById("devices");
-      var item = document.createElement('li');
 
       for (var i = 0; i < midi.devices.length; i++) {
+        var item = document.createElement('li');
         item.innerHTML = midi.devices[i].name;
         item.setAttribute('data-device', i);
         item.setAttribute('data-target', "5");