Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options were not propagating to EvaluationVisitor. #111

Merged
merged 9 commits into from Mar 18, 2024

Conversation

gumbarros
Copy link
Member

@gumbarros gumbarros commented Mar 8, 2024

This closes #110

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 93.18182% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.50%. Comparing base (21ea7fa) to head (2d06f78).

❗ Current head 2d06f78 differs from pull request most recent head 27cde9b. Consider uploading reports for the commit 27cde9b to get more accurate results

Files Patch % Lines
src/NCalc/Expression.cs 91.42% 3 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   74.37%   74.50%   +0.13%     
==========================================
  Files          21       21              
  Lines        4542     4562      +20     
  Branches      279      280       +1     
==========================================
+ Hits         3378     3399      +21     
+ Misses       1031     1029       -2     
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumbarros
Copy link
Member Author

@yallie let's merge this first before I fix #114 conflicts :)

@yallie yallie merged commit f4e3e73 into ncalc:master Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EvaluateOptions.IgnoreCase is not working in .net framework 4.6 version
3 participants