Using advice-around instead of hook trigger for mode enable. #6
+21
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original funcition `auto-sudoedit-sudoedit-and-kill' using buffer redirect method to replace the origin dired displayed buffer with the tramped one, and indeed that this procedure working for the hook both for `dired-mode-hook' or `find-file-hook' caused by the original `auto -sudoedit-mode' trigger. But for thus, the `kill-this-buffer' way will corrupted the origin buffer argument for the next hook rounder which will destroyed the whole dired or find-file initializing procedure. For avoiding this problem, this commit using the around-advices re-wrappering the `dired' and `find-file' which just transfer the tramp-transfered path for the rest process powered by the original package builtin function `auto-sudoedit-tramp-path'.
c0001
added a commit
to c0001/entropy-emacs
that referenced
this pull request
Jul 28, 2019
Original buffer-kill-replace mechanism will cause dired rest process corrupted, refer to the the PR: ncaq/auto-sudoedit#6 Waiting for merging.
ncaq
requested changes
Aug 1, 2019
auto-sudoedit.el
Outdated
| (let ((first-existing-path (f-traverse-upwards #'f-exists? curr-path))) | ||
| (unless (and first-existing-path (f-writable? first-existing-path)) | ||
| (auto-sudoedit-sudoedit-and-kill)))))) | ||
| (defun auto-sudoedit (_old_func &rest _args) |
There was a problem hiding this comment.
The args arguments is used.
However this naming starting underscore.
underscore show unused variable.
I think to should naming normal.
auto-sudoedit.el
Outdated
| (let ((tramp-path (auto-sudoedit-tramp-path curr-path))) | ||
| (apply _old_func tramp-path (cdr _args))) | ||
| (apply _old_func _args))) | ||
| (apply _old_func _args)))) |
|
Sorry for a week delayed thus. Thanks for your reviews, the naming convention problems has been fixed |
ncaq
approved these changes
Aug 9, 2019
c0001
added a commit
to c0001/entropy-emacs-extensions
that referenced
this pull request
Aug 9, 2019
Others: Update autosudoedit package commit refers to ncaq/auto-sudoedit#6
c0001
added a commit
to c0001/entropy-emacs
that referenced
this pull request
Aug 9, 2019
Tracking to the PR merged of ncaq/auto-sudoedit#6
This was referenced Aug 10, 2019
Merged
ncaq
added a commit
that referenced
this pull request
Apr 9, 2020
Using advice-around instead of hook trigger for mode enable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original funcition 'auto-sudoedit-sudoedit-and-kill' using buffer redirect method to replace the origin dired displayed buffer with the tramped one, and indeed that this procedure working for the hook both for 'dired-mode-hook' or 'find-file-hook' caused by the original 'auto -sudoedit-mode' trigger. But for thus, the 'kill-this-buffer' way will corrupted the origin buffer argument for the next hook rounder which will destroyed the whole dired or find-file initializing procedure.
For avoiding this problem, this commit using the around-advices re-wrappering the 'dired' and 'find-file' which just transfer the tramp-transfered path for the rest process powered by the original package builtin function 'auto-sudoedit-tramp-path'.