Fix bourne shell compatibility issues #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check jupyter status wasn't executed with a login shell. This results in ~/.profile or ~/.bash_profile not being sourced and ~/.local/bin not being in $PATH
The output redirection that is used in the command to launch Jupyter Lab isn't supported by the bourne shell, but only by bash (see https://www.ibm.com/docs/en/aix/7.1?topic=shell-input-output-redirection-in-bourne and https://www.gnu.org/software/bash/manual/html_node/Redirections.html). This results in an error on operating systems that don't symlink sh to bash (such as Ubuntu 20.04).
|
Thank you for this addition, @tobias-haenel, and welcome to the project :) 🎉 |
mnlevy1981
reviewed
Feb 11, 2022
| @@ -204,7 +204,7 @@ def _launch_jupyter(self): | |||
| command = r'jupyter lab --no-browser --ip=\$(hostname -f)' | |||
| if self.notebook_dir: | |||
| command = f'{command} --notebook-dir={self.notebook_dir}' | |||
| command = f'{command} >& {self.log_file}' | |||
| command = f'{command} > {self.log_file} 2>&1' | |||
There was a problem hiding this comment.
I'm concerned that this change is not compatible with tcsh and is actually reintroducing a bug fixed in #67. @tobias-haenel what sort of error do you see if you add the -l argument but keep the >& notation?
@andersy005 we should try to figure out how to create a test suite for jupyter-forward to prevent regressions like this... I suspect it can't be fully automated, but we definitely need to make sure all PRs are compatible with both bash and tcsh before accepting them
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced some compatibility issues with jupyter-forward on Ubuntu 20.04 that are related to bourne shell. Please see the commit messages that I wrote for the details. The changes are only 2 lines of code.