Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations #5

Open
jannone opened this issue Jul 27, 2017 · 24 comments
Open

Translations #5

jannone opened this issue Jul 27, 2017 · 24 comments

Comments

@jannone
Copy link

jannone commented Jul 27, 2017

I'd like to contribute with a translation, but I'm not sure how.

Could you give me some pointers?
Thanks

@gerardolm
Copy link

Same here, I could translate this to Spanish :)

@Feracitus
Copy link

Feracitus commented Jul 28, 2017

I'd like to make myself available to translate this into portuguese.
feracitus@hotmail.com

@toby3d
Copy link

toby3d commented Jul 28, 2017

I translate to Russian. :3
https://github.com/NotDotTeam/trust

@osaatcioglu
Copy link
Contributor

Same here. I would like to translate it to Turkish.

Also, I checked the code and it looks like words.html consists almost all the texts except the credits and may be some others. But, I couldn't make sure how the language selector works. I can contribute on creating a language selector in the UI as well.

This is very insightful and it should be shared more. Thanks.

@burbilog
Copy link

Yes, translation support is needed!

@Proxiweb
Copy link

I can translate to french

@KrzysztofMadejski
Copy link

KrzysztofMadejski commented Jul 28, 2017

All the texts are in the words.html file. Just fork this project and translate https://github.com/ncase/trust/blob/gh-pages/words.html. If author will introduce language picker it will be easy to pull-in.

PS. I'm close to find translators for Polish.

@KrzysztofMadejski
Copy link

  1. Fork the repo by clicking Fork in the top right corner
  2. Translate the words.html file by going to this url https://github.com/<account>/trust/edit/gh-pages/words.html (change <account> string to your username or organization name - where you forked the repo to)
  3. Go to https://<acount>.github.io/trust/ to see the effect live! Remeber to add the last slash after "trust", otherwise it won't work.

@ncase
Copy link
Owner

ncase commented Jul 28, 2017

Hi all! This is really great to see, that people are working on translations even before I could fully set up a translation system!

Originally I wanted to do something fancy where people could push translations without needing to make a new repo, but it turns out my code is completely not set up for that at all.

But yeah, basically: what @KrzysztofMadejski said! (Actually, there's one more thing: you also have to update index.html so that the title & social sharing links are different. And if you want to go the extra mile, you could also translate the footnotes at notes/index.html)

I'll update this repo soon-ish with a few fixes + official instructions for translating! Thank you all so much! <3

KrzysztofMadejski added a commit to kodujdlapolski/trust that referenced this issue Jul 28, 2017
KrzysztofMadejski added a commit to kodujdlapolski/trust that referenced this issue Jul 28, 2017
@jonathancross
Copy link
Contributor

Hey, everyone.
Seems there is a lot of us excited about this today :-)
I did a bit of experimentation to see if I could get translations working too:

I use Jekyll to reduce html duplication (no Javascript changes), yet this allows easy translation of strings in index.html and the rest of the site. I can see that @KrzysztofMadejski is already working on adding translations as well, but a different implementation direction using JS. Unfortunately this means the entire index.html file needs to be copied for each new language (instead of a simple file like this) and you don't get clean urls (/de/ for German, /es/ for Spanish).

Setting up a new language is acomplished by copying the en folder to a new name like de, then translating the strings. We probably need to also adjust font-sizes, etc, but should be easy.

Note: my repo would need to be rebased over a fork of this repo before I could create a pull request. You can see diff here. I'm waiting on #8 to be closed or merged.

@ncase
Copy link
Owner

ncase commented Jul 29, 2017

image

I've put up a really rough step-by-step translation guide!
https://github.com/ncase/trust#how-to-translate-this-thang

I also added a comments in index.html and words.html to help you figure out what to translate and how! There's some weird rules about what to and what not to translate (for example, don't translate anything in [square brackets], because I'm using them as markers for string replacement), so hopefully the comments clear those up. Maybe.

Again, many, many sincere thanks that so many of you want to help!

I TRUST YOU <3

@KrzysztofMadejski
Copy link

@jonathancross it's a cool idea to use Jekyll.

Pros:

  • deduplication of same strings
  • simpler file for translators

Cons:

  • it's no more static site, Jekyll has to be invoked if site is being hosted outside of Jekyll-supported container (ie. outside of Github Pages).

--

@ncase do you plan to add language chooser on the main page? Will you link to other repos or host all translations here?

@coppolaemilio
Copy link

@KrzysztofMadejski I think that having a language selector on the main page is a must because I already see my social media walls full of links to the original one. I personally know a lot of people that would not be able to enjoy it because they don't speak English. Without a language selector they would need to know the specific url and it would mean that less people is going to be able to enjoy it in their native language from the links that are already out there.

@brunolemos
Copy link

@ncase loved what you built, congrats!

Just translated to Portuguese (Brazil):

Link: https://brunolemos.github.io/trust/
Repo: https://github.com/brunolemos/trust

Edits are welcome cc @Feracitus
Thanks!

@jonathancross
Copy link
Contributor

jonathancross commented Jul 29, 2017

@KrzysztofMadejski Yes, agree with your assessment generally. If @ncase is okay with the static / jekyll tradeoff (which solves #11 (comment) and is better for SEO / localization). We can also add nice things like compiling all JS into one file, etc.

@coppolaemilio I'd recommend that the first translations be made and accessible via unique URL, then making the language selector can be added (behavior will be simple at that point).

@brunolemos Added your pt-BR translation (less than 1 minute): https://jonathancross.github.io/pt/
I see there are also changes to display styles (not implemented). We will need to define a way to abstract these so they are common for all langs (this is best) and / or provide a simple interface to tweak per-language settings if really needed. I'm thinking this could be just a JSON structure of overrides embedded into the index.html?

@ncase
Copy link
Owner

ncase commented Jul 30, 2017

@brunolemos: Awesome, thank you so so much! :D I'll link to it from the main site later. (Also, a few other people also emailed me offering to translate to PT-BR, I let them know about your version & mentioned the footnotes are yet un-translated, they could try translating those. So, expect some pull requests on your repo later!)

@MattBow
Copy link

MattBow commented Aug 1, 2017

There is a Chinese version: https://github.com/DCCXI/trust-zh-CN and he or she has made a website to run the game(http://sekai.co/trust/). He or she is new to use git/github, therefore the branch name is not as required, but I think our forum will do the help. Lastly, awesome idea and interactive game, thank you very much!

@jkoelling
Copy link

jkoelling commented Aug 1, 2017

@jonathancross I'd be happy to help with the German translation if needed. Is anyone else already working on it?

Update 1: I started on the German translation: https://github.com/jkoelling/trust
Let me know if you want to help or already have something yourself.

Update 2: I finished translating the game (words.html and index.html). Now I only have to check for errors and inconsistencies.

Update 3: Finished and is now included in the original. There are still some rough edges around resetting text + other elements and I'm sure there are still some typos too.

@agatku
Copy link
Contributor

agatku commented Aug 1, 2017

Just letting you all know that I started working on a polish translation at agagata/trust. If anyone's interested, feel free to join me. :) [I'm already in touch with @KrzysztofMadejski]

@ncase
Copy link
Owner

ncase commented Aug 2, 2017

Hi everyone! Sorry for the delay, I've been swamped trying to prepare some things for this other thing which is thing thing thing

Anyway, I've added a basic language picker to the opening screen of The Evolution of Trust! It's just a link to the two full translations that exist so far (Chinese & Brazilian Portuguese) plus a link to the how-to for translating it yourself

image

I'll update it as more translations come rolling in -- thank you all again so much! :)

@gerardolm
Copy link

gerardolm commented Aug 2, 2017

Hey, are the CHEAT and COOPERATE buttons on Chapter 1 not translatable? I'm halfway through the whole thing (to Spanish)... Layout is a bitch and I'm having some difficulties shortening text, but it's coming out nicely so far.

Nvm, I found those labels are further down in the file.

@brunolemos
Copy link

@ncase I added analytics on pt-br version, 15k sessions so far! Very cool.
I imagine the english version is dozens of times more, of course; could you share the number?

image

@ncase
Copy link
Owner

ncase commented Aug 11, 2017

Wow @brunolemos, that's amazing! I don't put analytics on most of my stuff -- but looking at the number of social shares via sharedcount.com (153.7k Facebook shares), and multiplying that by the ratio of plays/shares for a previous game (60 plays per Facebook share), I estimate... 9 million plays? :O

@brunolemos
Copy link

Amazing!

mupsycho pushed a commit to mupsylab/game-trust that referenced this issue Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests