adjusting scroll behavior for backwards compatibility

ncb000gt · Mar 5, 2019 · af14be7 · af14be7
1 parent 277fd5c
commit af14be7
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,3 +1,7 @@
+# v0.7.1 / 2019-03-05
+
+* Adjusted `scroll` method to construct proper scroll payload when only the ID is specified
+
 # v0.7.0 / 2019-02-20
 
 * Replaced `thenify` and `bluebird` dependencies with `babel`

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "es",
   "description": "API around the ElasticSearch RESTful API -- mostly convenience.",
   "main": "dist",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "author": "Nick Campbell (http://github.com/ncb000gt)",
   "contributors": [
     "Nick Campbell (http://github.com/ncb000gt)",

diff --git a/src/core.js b/src/core.js
@@ -577,6 +577,14 @@ class Core {
 		options.query = utils.exclude(options, this.paramExcludes);
 		options.path = utils.pathAppend('_search/scroll');
 
+		// re-map to payload expected by ES6
+		if (typeof scrollId === 'string') {
+			scrollId = {
+				scroll : options.scroll,
+				'scroll_id' : scrollId
+			};
+		}
+
 		// documentation indicates GET method...
 		// sending POST data via GET not typical, using POST instead
 		return this.request.post(options, scrollId, callback);