Improvement/60 light dark themes #103
Conversation
| */ | ||
| function set_theme(file) | ||
| { | ||
| var oldlink = document.getElementsByTagName("link").item(THEME_INDEX); |
There was a problem hiding this comment.
I think getting the link element holding the theme with an id instead of with an index would be more reliable. This solution breaks if the lines are moved around or if we add another link tag before.
There was a problem hiding this comment.
I think a light & dark themes are sufficient, but it would be nice if the implementation allows to easily swap themes.
There was a problem hiding this comment.
After a clean clone + execution I now see the issue you mention. When working on the project I modified files in /scoutsuite-report in order to skip the process of making a report each time, I must've poorly transfered over my changes to the /ScoutSuite. Will fix.
EDIT: Found the cause. |
This comment has been minimized.
This comment has been minimized.
This PR adds a secondary (dark) theme that can be toggled on by clicking on the slider after opening the settings' drop-down menu. The theme is applied instantly and reapplied if needed each time the .html report is opened.
The visual of both themes isn't definitive since @j4v brought to my attention that #59 should've been completed prior to #60. Therefore I'll make the required adjustments to #60 after completing #59, which includes new bootstrap 4 themes.
Here's a collage of the default theme (renamed to light) and dark theme :
