Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2 cloudtrail findings #126

Merged
merged 8 commits into from Jan 30, 2019
Merged

Conversation

vifor2
Copy link
Contributor

@vifor2 vifor2 commented Jan 30, 2019

This PR adds 3 finding rules related to CloudTrails, see https://github.com/nccgroup/ScoutSuite-Proprietary/issues/2.

  • Management events
  • Data events
  • KMS key

Prorietary portion : https://github.com/nccgroup/ScoutSuite-Proprietary/pull/53

@x4v13r64
Copy link
Collaborator

My only comment (and I'm realizing this isn't specific to this PR) is whether value names should be in camel case or underscored (DataEventsEnabled, DataEventsEnabled, etc.).

Applied @Aboisier's suggestion

Co-Authored-By: vifor2 <fortin.vincent@hotmail.com>
@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #126 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #126      +/-   ##
===========================================
+ Coverage    30.31%   30.31%   +<.01%     
===========================================
  Files           63       63              
  Lines         4097     4351     +254     
===========================================
+ Hits          1242     1319      +77     
- Misses        2855     3032     +177
Impacted Files Coverage Δ
ScoutSuite/providers/aws/services/cloudtrail.py 18.33% <0%> (-0.97%) ⬇️
ScoutSuite/providers/azure/configs/services.py 60% <0%> (-15%) ⬇️
ScoutSuite/providers/aws/configs/base.py 42.85% <0%> (-9.78%) ⬇️
ScoutSuite/providers/azure/provider.py 22.82% <0%> (-8.76%) ⬇️
ScoutSuite/providers/azure/configs/base.py 41.37% <0%> (-8.63%) ⬇️
ScoutSuite/providers/gcp/configs/services.py 50% <0%> (-4.84%) ⬇️
ScoutSuite/providers/aws/configs/services.py 52% <0%> (-2.17%) ⬇️
ScoutSuite/providers/gcp/configs/base.py 15.47% <0%> (-1.2%) ⬇️
ScoutSuite/cli_parser.py 73.38% <0%> (-0.64%) ⬇️
ScoutSuite/providers/base/provider.py 9.82% <0%> (-0.39%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0d0ff...8b0eb34. Read the comment docs.

Aboisier and others added 3 commits January 30, 2019 08:46
…egions.id.trails.html

Co-Authored-By: vifor2 <fortin.vincent@hotmail.com>
…egions.id.trails.html

Co-Authored-By: vifor2 <fortin.vincent@hotmail.com>
…egions.id.trails.html

Co-Authored-By: vifor2 <fortin.vincent@hotmail.com>
@vifor2 vifor2 merged commit 6dd7503 into develop Jan 30, 2019
@vifor2 vifor2 deleted the feature/2-cloudtrail-findings branch January 30, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants