New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2 cloudtrail findings #126
Conversation
ScoutSuite/output/data/html/partials/aws/services.cloudtrail.regions.id.trails.html
Outdated
Show resolved
Hide resolved
ScoutSuite/output/data/html/partials/aws/services.cloudtrail.regions.id.trails.html
Outdated
Show resolved
Hide resolved
ScoutSuite/output/data/html/partials/aws/services.cloudtrail.regions.id.trails.html
Outdated
Show resolved
Hide resolved
My only comment (and I'm realizing this isn't specific to this PR) is whether value names should be in camel case or underscored ( |
Applied @Aboisier's suggestion Co-Authored-By: vifor2 <fortin.vincent@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #126 +/- ##
===========================================
+ Coverage 30.31% 30.31% +<.01%
===========================================
Files 63 63
Lines 4097 4351 +254
===========================================
+ Hits 1242 1319 +77
- Misses 2855 3032 +177
Continue to review full report at Codecov.
|
…egions.id.trails.html Co-Authored-By: vifor2 <fortin.vincent@hotmail.com>
…egions.id.trails.html Co-Authored-By: vifor2 <fortin.vincent@hotmail.com>
…egions.id.trails.html Co-Authored-By: vifor2 <fortin.vincent@hotmail.com>
This PR adds 3 finding rules related to CloudTrails, see https://github.com/nccgroup/ScoutSuite-Proprietary/issues/2.
Prorietary portion : https://github.com/nccgroup/ScoutSuite-Proprietary/pull/53