Feature/1 iam findings

[vifor2]

PR for https://github.com/nccgroup/ScoutSuite-Proprietary/issues/1

• Lack of Access Key Rotation : was already done.
• Lack of AWS CMK Key Rotation : now fetching the data of an additional service (KMS) : to see the variation of the finding's output you can toggle the rotation of one or multiple keys here :
  [removed as included AWS account number]

The finding can be seen here :

• Managed Policy Allows NotActions : was already done.
• User With Password and Key Enabled : was already done.

[vifor2]

Proprietary part : https://github.com/nccgroup/ScoutSuite-Proprietary/pull/65

[codecov-io]

Codecov Report

Merging #141 into develop will increase coverage by 0.1%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           develop     #141     +/-   ##
==========================================
+ Coverage    30.25%   30.35%   +0.1%     
==========================================
  Files           64       65      +1     
  Lines         4191     4213     +22     
==========================================
+ Hits          1268     1279     +11     
- Misses        2923     2934     +11

Impacted Files	Coverage Δ
ScoutSuite/providers/aws/services/iam.py	10.67% <0%> (ø)	⬆️
ScoutSuite/providers/aws/configs/services.py	54% <50%> (-0.17%)	⬇️
ScoutSuite/providers/aws/services/kms.py	50% <50%> (ø)
ScoutSuite/providers/azure/utils.py	27.77% <0%> (-0.8%)	⬇️
ScoutSuite/providers/azure/configs/services.py	69.23% <0%> (+2.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f25ba87...338ad7a. Read the comment docs.

[codecov-io]

Codecov Report

Merging #141 into develop will increase coverage by 0.66%.
The diff coverage is 29.16%.

@@             Coverage Diff             @@
##           develop     #141      +/-   ##
===========================================
+ Coverage    30.25%   30.91%   +0.66%     
===========================================
  Files           64       65       +1     
  Lines         4191     4370     +179     
===========================================
+ Hits          1268     1351      +83     
- Misses        2923     3019      +96

Impacted Files	Coverage Δ
ScoutSuite/providers/aws/services/iam.py	10.67% <0%> (ø)	⬆️
ScoutSuite/providers/aws/services/kms.py	33.33% <33.33%> (ø)
ScoutSuite/providers/aws/configs/services.py	54% <50%> (-0.17%)	⬇️
ScoutSuite/providers/azure/provider.py	16.32% <0%> (-4.23%)	⬇️
ScoutSuite/providers/gcp/provider.py	13.37% <0%> (-1.81%)	⬇️
ScoutSuite/providers/azure/utils.py	27.77% <0%> (-0.8%)	⬇️
ScoutSuite/cli_parser.py	77.85% <0%> (+1.95%)	⬆️
ScoutSuite/providers/azure/configs/services.py	69.23% <0%> (+2.56%)	⬆️
ScoutSuite/__main__.py	70.49% <0%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f25ba87...4a61a00. Read the comment docs.

[x4v13r64]

• User With Password and Key Enabled : was already done.

Ah I see why I missed this, it's disabled in the default ruleset:

        "iam-user-with-password-and-key.json": [
            {
                "enabled": false,
                "level": "warning"
            }

[x4v13r64]

A view should also be implemented for KMS key resources.

[vifor2]

A view should also be implemented for KMS key resources.

Alright, will do

[vifor2]

Sorry for the delay, been pretty busy this week 😐
Added the view for KMS keys, attributes visible are alias name, descrition, id and arn. The page being accessible under Security-->KMS-->Keys