Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/145 Azure switches for credentials #147

Merged
merged 2 commits into from Feb 4, 2019
Merged

Feature/145 Azure switches for credentials #147

merged 2 commits into from Feb 4, 2019

Conversation

zer0x64
Copy link
Contributor

@zer0x64 zer0x64 commented Feb 4, 2019

As required for #145 . This code allow users to pass azure credentials with the command line and asks them interactively if it is not present.

@zer0x64 zer0x64 added enhancement New feature or request component-provider-azure Affects Azure provider labels Feb 4, 2019
@zer0x64 zer0x64 self-assigned this Feb 4, 2019
@x4v13r64
Copy link
Collaborator

x4v13r64 commented Feb 4, 2019

Tested it out, worked 💯

@x4v13r64
Copy link
Collaborator

x4v13r64 commented Feb 4, 2019

Might want to merge develop into this branch first, seems it's a bit behind.

@zer0x64
Copy link
Contributor Author

zer0x64 commented Feb 4, 2019

Might want to merge develop into this branch first, seems it's a bit behind.

Done!

@zer0x64 zer0x64 merged commit 84255ab into develop Feb 4, 2019
@zer0x64 zer0x64 deleted the feature/145-azure-creds-cmd branch February 4, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4v13r64 x4v13r64 x4v13r64 approved these changes

@Aboisier Aboisier Aboisier approved these changes

@misg misg Awaiting requested review from misg

@vifor2 vifor2 Awaiting requested review from vifor2

@Remi05 Remi05 Awaiting requested review from Remi05

Assignees

@zer0x64 zer0x64

Labels
component-provider-azure Affects Azure provider enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zer0x64 @x4v13r64 @Aboisier