Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/#26-new-finding-azure-sql-no-replication-configured #161

Merged

Conversation

misg
Copy link
Contributor

@misg misg commented Feb 8, 2019

This PR parses geo-replication config of SQL databases.
Please look at the proprietary PR as well.

@misg misg changed the title Merge branch 'develop' of https://github.com/nccgroup/ScoutSuite into feature/#26-new-finding-azure-sql-no-replication-configured feature/#26-new-finding-azure-sql-no-replication-configured Feb 8, 2019
@misg misg self-assigned this Feb 8, 2019
@misg misg added enhancement New feature or request component-findings Affects findings component-provider-azure Affects Azure provider labels Feb 8, 2019
@misg misg added this to In progress in Scout Suite via automation Feb 8, 2019
@misg misg added this to the Iteration #2 milestone Feb 8, 2019
@codecov-io
Copy link

codecov-io commented Feb 8, 2019

Codecov Report

Merging #161 into develop will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #161      +/-   ##
===========================================
+ Coverage    30.28%   30.28%   +<.01%     
===========================================
  Files           66       66              
  Lines         4316     4322       +6     
===========================================
+ Hits          1307     1309       +2     
- Misses        3009     3013       +4
Impacted Files Coverage Δ
ScoutSuite/providers/azure/services/sqldatabase.py 28% <33.33%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347d65b...cbd3b1e. Read the comment docs.

@misg misg merged commit bf0deb1 into develop Feb 10, 2019
Scout Suite automation moved this from In progress to Done Feb 10, 2019
@misg misg deleted the feature/#26-new-finding-azure-sql-no-replication-configured branch February 10, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-findings Affects findings component-provider-azure Affects Azure provider enhancement New feature or request
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants