Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1621 Improve AWS unused credential issue flagging #1623

Conversation

rieck-srlabs
Copy link
Contributor

Description

This PR partly fixes #1621

With the changes, ScoutSuite ignores inactive / disabled credentials for the "Credentials Unused for 90 Days or Greater Are Not Disabled" rule in ScoutSuite. The change does not address point 3 of the issue, namely:

  1. (Active access keys that have recently been used are also highlighted in red, as long as there is another access key that has not been used recently. Note that this problem is not highlighted in the screenshot above)

I don't believe this last point can feasibly be addressed, as the HTML frontend would need to know about the configurable argument to the rule.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.56%. Comparing base (7a6e3c7) to head (e500930).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1623   +/-   ##
========================================
  Coverage    20.56%   20.56%           
========================================
  Files          385      385           
  Lines        13067    13065    -2     
========================================
  Hits          2687     2687           
+ Misses       10380    10378    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fernando-gallego fernando-gallego self-assigned this May 8, 2024
@fernando-gallego fernando-gallego merged commit c1434c2 into nccgroup:develop May 8, 2024
8 checks passed
@rieck-srlabs rieck-srlabs deleted the bugfix/1621-improve-aws-unused-credentials branch May 13, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants