Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/#24-new-finding-azure-load-balancer #187

Merged
merged 4 commits into from Feb 18, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Feb 17, 2019

This PR adds support for Load Balancer service.
Please look at the proprietary PR as well.

@misg misg self-assigned this Feb 17, 2019
@misg misg added enhancement New feature or request component-provider-azure Affects Azure provider labels Feb 17, 2019
@misg misg added this to In progress in Scout Suite via automation Feb 17, 2019
@misg misg added this to the Iteration #2 milestone Feb 17, 2019
@codecov-io
Copy link

Codecov Report

Merging #187 into develop will decrease coverage by 0.04%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #187      +/-   ##
===========================================
- Coverage    29.92%   29.87%   -0.05%     
===========================================
  Files           68       68              
  Lines         4448     4539      +91     
===========================================
+ Hits          1331     1356      +25     
- Misses        3117     3183      +66
Impacted Files Coverage Δ
ScoutSuite/utils.py 92.85% <ø> (ø) ⬆️
ScoutSuite/providers/azure/utils.py 32.35% <0%> (-2.03%) ⬇️
ScoutSuite/providers/azure/configs/services.py 53.84% <50%> (-1%) ⬇️
ScoutSuite/providers/aws/configs/services.py 51.56% <0%> (-1.89%) ⬇️
ScoutSuite/providers/aws/services/iam.py 14.02% <0%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83efd55...3a264a7. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #187 into develop will increase coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #187      +/-   ##
===========================================
+ Coverage    29.46%   29.48%   +0.02%     
===========================================
  Files           69       69              
  Lines         4562     4572      +10     
===========================================
+ Hits          1344     1348       +4     
- Misses        3218     3224       +6
Impacted Files Coverage Δ
ScoutSuite/utils.py 92.85% <ø> (ø) ⬆️
ScoutSuite/providers/azure/utils.py 30.76% <0%> (-1.67%) ⬇️
ScoutSuite/providers/azure/configs/services.py 53.06% <50%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d40213...a5b490e. Read the comment docs.

Aboisier
Aboisier previously approved these changes Feb 17, 2019
vifor2
vifor2 previously approved these changes Feb 17, 2019
x4v13r64
x4v13r64 previously approved these changes Feb 18, 2019
# Conflicts:
#	ScoutSuite/output/data/inc-scoutsuite/scoutsuite.js
#	ScoutSuite/providers/azure/configs/services.py
#	ScoutSuite/providers/azure/metadata.json
#	ScoutSuite/providers/azure/utils.py
#	ScoutSuite/utils.py
@misg misg dismissed stale reviews from x4v13r64, vifor2, and Aboisier via a5b490e February 18, 2019 14:45
@misg misg merged commit 814c2ef into develop Feb 18, 2019
Scout Suite automation moved this from In progress to Done Feb 18, 2019
@misg misg deleted the feature/#24-new-finding-azure-load-balancer branch February 18, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-provider-azure Affects Azure provider enhancement New feature or request
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants