Feature/9 ec2 findings #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aboisier
added
enhancement
Codecov Report
@@ Coverage Diff @@
## develop #191 +/- ##
===========================================
- Coverage 29.43% 29.42% -0.02%
===========================================
Files 69 69
Lines 4546 4551 +5
===========================================
+ Hits 1338 1339 +1
- Misses 3208 3212 +4
Continue to review full report at Codecov.
|
vifor2
approved these changes
Feb 18, 2019
x4v13r64
reviewed
Feb 18, 2019
| @@ -115,6 +116,10 @@ def _add_security_group_name_to_ec2_grants(self): | |||
| self.add_security_group_name_to_ec2_grants_callback, | |||
| {'AWSAccountId': self.aws_account_id}) | |||
|
|
|||
| def _check_ec2_zone_distribution(self): | |||
x4v13r64
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a proprietary feature (#9). It adds a check for the number of availability zones having one or more EC2 instances deployed and the monitoring state.
Please also review the proprietary PR.