Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/11 aws config not enabled #196

Merged
merged 9 commits into from Feb 20, 2019
Merged

Conversation

vifor2
Copy link
Contributor

@vifor2 vifor2 commented Feb 19, 2019

PR for https://github.com/nccgroup/ScoutSuite-Proprietary/issues/11
Please also consult the private PR (most stuff is over there)

In this public part I have :

  • Added the api call in metadata to fetch recorder information for the ConfigService
  • Added try/catch to call private components of ConfigService
  • Changed the 2 instances where my service name was messed with and replaced the function with a regex

@vifor2 vifor2 added enhancement New feature or request component-provider-aws Affects AWS provider labels Feb 19, 2019
@vifor2 vifor2 added this to the Iteration #3 milestone Feb 19, 2019
@vifor2 vifor2 self-assigned this Feb 19, 2019
@vifor2 vifor2 added this to In progress in Scout Suite via automation Feb 19, 2019
@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #196 into develop will increase coverage by 0.05%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #196      +/-   ##
===========================================
+ Coverage    29.49%   29.54%   +0.05%     
===========================================
  Files           68       68              
  Lines         4567     4576       +9     
===========================================
+ Hits          1347     1352       +5     
- Misses        3220     3224       +4
Impacted Files Coverage Δ
ScoutSuite/utils.py 92.85% <ø> (ø) ⬆️
ScoutSuite/providers/aws/configs/regions.py 17.17% <0%> (ø) ⬆️
ScoutSuite/providers/base/configs/base.py 20.86% <50%> (+0.57%) ⬆️
ScoutSuite/providers/aws/configs/services.py 52.77% <50%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0e712...2fed4a3. Read the comment docs.

@vifor2 vifor2 merged commit fb177c6 into develop Feb 20, 2019
Scout Suite automation moved this from In progress to Done Feb 20, 2019
@vifor2 vifor2 deleted the feature/11-aws-config-not-enabled branch February 20, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-provider-aws Affects AWS provider enhancement New feature or request
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants