Feature/57 gcp cloud storage findings prop #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #205 +/- ##
========================================
Coverage 29.41% 29.41%
========================================
Files 68 68
Lines 4597 4597
========================================
Hits 1352 1352
Misses 3245 3245Continue to review full report at Codecov.
|
Aboisier
added
enhancement
|
Looks good to me! 💯 |
Remi05
approved these changes
Feb 25, 2019
misg
approved these changes
Feb 25, 2019
x4v13r64
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #57 on the proprietary side. CIS 5.1 and 5.3 were already implemented, I added their rationales and CIS numbers. With the current API, CIS 5.2 would require hours to complete, since it requires potentially getting millions of bucket objects. See #101 .