Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/207 exceptions #209

Merged
merged 5 commits into from Feb 28, 2019
Merged

Bugfix/207 exceptions #209

merged 5 commits into from Feb 28, 2019

Conversation

x4v13r64
Copy link
Collaborator

Fix for #207.

I've moved back the profile list argument parsing to the __main__.py file and removed it from the provider.py. Maybe there would be a way to ensure in ArgParse that there's only 1 parameter, so that the arg isn't a list?

@x4v13r64 x4v13r64 added bug Something isn't working component-core Affects core labels Feb 27, 2019
@codecov-io
Copy link

codecov-io commented Feb 27, 2019

Codecov Report

Merging #209 into develop will increase coverage by 0.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
+ Coverage     29.7%   29.94%   +0.23%     
===========================================
  Files           74       74              
  Lines         5430     5430              
===========================================
+ Hits          1613     1626      +13     
+ Misses        3817     3804      -13
Impacted Files Coverage Δ
ScoutSuite/__main__.py 67.03% <100%> (ø) ⬆️
ScoutSuite/providers/aws/provider.py 10.31% <33.33%> (ø) ⬆️
ScoutSuite/core/exceptions.py 50% <0%> (+4.54%) ⬆️
ScoutSuite/output/js.py 37.5% <0%> (+9.37%) ⬆️
ScoutSuite/output/utils.py 39.47% <0%> (+15.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa69b9...15cd803. Read the comment docs.

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@x4v13r64 x4v13r64 merged commit 81a7792 into develop Feb 28, 2019
@zer0x64 zer0x64 deleted the bugfix/207-exceptions branch March 10, 2019 00:20
@zer0x64 zer0x64 restored the bugfix/207-exceptions branch March 10, 2019 00:20
@zer0x64 zer0x64 deleted the bugfix/207-exceptions branch March 10, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component-core Affects core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants