Cleanup/warnings core #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vifor2
reviewed
Feb 28, 2019
| awsscout2_conditions_dir = os.path.join(awsscout2_rules_data_dir, 'conditions') | ||
| awsscout2_filters_dir = os.path.join(awsscout2_rules_data_dir, 'filters') | ||
| awsscout2_findings_dir = os.path.join(awsscout2_rules_data_dir, 'findings') | ||
| awsscout2_rulesets_dir = os.path.join(awsscout2_rules_data_dir, 'rulesets') |
There was a problem hiding this comment.
But I liked the equals lining up 😿
vifor2
approved these changes
Feb 28, 2019
x4v13r64
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR aims to remove all the easy-to-remove warnings in the core/ folder. This includes PEP8 format, arguments not in docstrings, unused variables, etc.