Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3.0 hotfixes #225

Merged
merged 1 commit into from Mar 6, 2019
Merged

4.3.0 hotfixes #225

merged 1 commit into from Mar 6, 2019

Conversation

zer0x64
Copy link
Contributor

@zer0x64 zer0x64 commented Mar 6, 2019

PR to do small modifications required for 4.3.0 release.

@zer0x64 zer0x64 self-assigned this Mar 6, 2019
@codecov-io
Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #225 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #225   +/-   ##
========================================
  Coverage    30.47%   30.47%           
========================================
  Files           73       73           
  Lines         5067     5067           
========================================
  Hits          1544     1544           
  Misses        3523     3523

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0441a20...8f7d14a. Read the comment docs.

@vifor2 vifor2 added this to In progress in Scout Suite via automation Mar 6, 2019
@x4v13r64
Copy link
Collaborator

x4v13r64 commented Mar 6, 2019

Is this because requests is included in boto3?

@zer0x64
Copy link
Contributor Author

zer0x64 commented Mar 6, 2019

Is this because requests is included in boto3?

Requests is not used directly anymore AFAIK and I wanted to remove the "Opinel" section of the dependency!

@Aboisier Aboisier merged commit 4f1264c into develop Mar 6, 2019
Scout Suite automation moved this from In progress to Done Mar 6, 2019
@x4v13r64
Copy link
Collaborator

x4v13r64 commented Mar 6, 2019

Requests is not used directly anymore AFAIK

You're right, my bad 😅

@zer0x64 zer0x64 deleted the release-adjustments branch March 6, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants