Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/elb #257

Merged
merged 17 commits into from Mar 25, 2019
Merged

Refactoring/aws/elb #257

merged 17 commits into from Mar 25, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 16, 2019

This PR aims to migrate AWS ELB service to the new architecture, as part of #183.
Please note that I got rid of the elb policies since they weren't used anywhere.

@misg misg self-assigned this Mar 16, 2019
@misg misg added this to In progress in Scout Suite via automation Mar 16, 2019
@misg misg added this to the Iteration #4 milestone Mar 16, 2019
@Aboisier Aboisier mentioned this pull request Mar 16, 2019
53 tasks
@codecov-io
Copy link

codecov-io commented Mar 16, 2019

Codecov Report

Merging #257 into refactoring/resource-configs will increase coverage by 0.35%.
The diff coverage is 46.03%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #257      +/-   ##
================================================================
+ Coverage                         31.32%   31.67%   +0.35%     
================================================================
  Files                               140      143       +3     
  Lines                              5784     5761      -23     
================================================================
+ Hits                               1812     1825      +13     
+ Misses                             3972     3936      -36
Impacted Files Coverage Δ
ScoutSuite/providers/aws/provider.py 9.83% <ø> (+0.07%) ⬆️
...uite/providers/aws/resources/elb/load_balancers.py 26.08% <26.08%> (ø)
ScoutSuite/providers/aws/facade/elb.py 45.83% <45.83%> (ø)
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️
ScoutSuite/providers/aws/facade/facade.py 44.44% <50%> (+7.45%) ⬆️
ScoutSuite/providers/aws/resources/elb/service.py 83.33% <83.33%> (ø)
ScoutSuite/providers/aws/resources/elb/vpcs.py 83.33% <83.33%> (ø)
ScoutSuite/output/js.py 25% <0%> (-0.36%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf7369...23afc64. Read the comment docs.

@Aboisier Aboisier self-requested a review March 25, 2019 15:00
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💯

@misg misg merged commit a93bcde into refactoring/resource-configs Mar 25, 2019
Scout Suite automation moved this from In progress to Done Mar 25, 2019
@misg misg deleted the refactoring/aws/elb branch March 25, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants