Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/sns #265

Merged
merged 9 commits into from Mar 25, 2019
Merged

Refactoring/aws/sns #265

merged 9 commits into from Mar 25, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 18, 2019

This PR aims to migrate AWS SNS service to the new architecture, as part of #183.
Please note that I removed subscriptions resources from the metadata.json file because they are already included in their topics resources (and displayed as so in the report, see above picture).

image

@misg misg self-assigned this Mar 18, 2019
@misg misg added this to In progress in Scout Suite via automation Mar 18, 2019
@misg misg added this to the Iteration #4 milestone Mar 18, 2019
@codecov-io
Copy link

codecov-io commented Mar 18, 2019

Codecov Report

Merging #265 into refactoring/resource-configs will increase coverage by 0.24%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #265      +/-   ##
================================================================
+ Coverage                         30.98%   31.23%   +0.24%     
================================================================
  Files                               130      141      +11     
  Lines                              5641     5869     +228     
================================================================
+ Hits                               1748     1833      +85     
- Misses                             3893     4036     +143
Impacted Files Coverage Δ
...Suite/providers/aws/resources/sns/subscriptions.py 26.66% <26.66%> (ø)
ScoutSuite/providers/aws/resources/sns/topics.py 33.33% <33.33%> (ø)
ScoutSuite/providers/aws/facade/sns.py 39.28% <39.28%> (ø)
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️
ScoutSuite/providers/aws/facade/facade.py 37.5% <6.66%> (-6.36%) ⬇️
ScoutSuite/providers/aws/resources/sns/service.py 83.33% <83.33%> (ø)
ScoutSuite/output/js.py 25% <0%> (-0.36%) ⬇️
...tSuite/providers/aws/resources/rds/subnetgroups.py 50% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e95ff...b050bb4. Read the comment docs.

@Aboisier Aboisier mentioned this pull request Mar 18, 2019
53 tasks
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@misg misg merged commit 2cf7369 into refactoring/resource-configs Mar 25, 2019
Scout Suite automation moved this from In progress to Done Mar 25, 2019
@misg misg deleted the refactoring/aws/sns branch March 25, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants