Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated new config service implementation #272

Merged
merged 1 commit into from Mar 21, 2019
Merged

Integrated new config service implementation #272

merged 1 commit into from Mar 21, 2019

Conversation

Aboisier
Copy link
Contributor

@Aboisier Aboisier commented Mar 21, 2019 •
edited

This PR migrates config service to the new implementation, see #183 . It is the public part of a proprietary feature.

@Aboisier Aboisier added this to the Iteration #5 milestone Mar 21, 2019
@Aboisier Aboisier self-assigned this Mar 21, 2019
@Aboisier Aboisier added this to In progress in Scout Suite via automation Mar 21, 2019
@Aboisier Aboisier mentioned this pull request Mar 21, 2019
Closed
53 tasks
vifor2
vifor2 approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

misg
misg approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Aboisier Aboisier merged commit 7f855ab into refactoring/resource-configs Mar 21, 2019
Scout Suite automation moved this from In progress to Done Mar 21, 2019
@Aboisier Aboisier deleted the refactoring/aws/config branch March 21, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misg misg misg approved these changes

@vifor2 vifor2 vifor2 approved these changes

@x4v13r64 x4v13r64 Awaiting requested review from x4v13r64

@Remi05 Remi05 Awaiting requested review from Remi05

@zer0x64 zer0x64 Awaiting requested review from zer0x64

Assignees

@Aboisier Aboisier

Labels
component-provider-aws Affects AWS provider providers-refactoring refactoring
Projects
No open projects
Scout Suite
  
Done
Milestone
Iteration #5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Aboisier @misg @vifor2