Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve concurrent support for AWS services #288

Merged
merged 31 commits into from Mar 31, 2019

Conversation

Aboisier
Copy link
Contributor

This PR aims to address the TODOs left during the refactoring (#183).

@Aboisier Aboisier requested a review from misg March 27, 2019 14:43
@Aboisier Aboisier added the WIP label Mar 27, 2019
@misg misg requested review from Remi05 and x4v13r64 and removed request for misg March 30, 2019 19:21
@misg misg self-assigned this Mar 30, 2019
@misg misg self-requested a review March 30, 2019 19:21
@misg misg added enhancement New feature or request component-provider-aws Affects AWS provider providers-refactoring and removed WIP labels Mar 30, 2019
@misg misg added this to In progress in Scout Suite via automation Mar 30, 2019
@misg misg added this to the Iteration #5 milestone Mar 30, 2019
@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #288 into refactoring/resource-configs will increase coverage by 0.09%.
The diff coverage is 27.27%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #288      +/-   ##
================================================================
+ Coverage                         33.66%   33.75%   +0.09%     
================================================================
  Files                               161      161              
  Lines                              5686     5706      +20     
================================================================
+ Hits                               1914     1926      +12     
- Misses                             3772     3780       +8
Impacted Files Coverage Δ
ScoutSuite/providers/aws/resources/ec2/vpcs.py 100% <ø> (ø) ⬆️
...tSuite/providers/aws/resources/elasticache/vpcs.py 85.71% <ø> (-3.18%) ⬇️
...coutSuite/providers/aws/resources/rds/snapshots.py 21.05% <ø> (-3.95%) ⬇️
...iders/aws/resources/elasticache/parametergroups.py 40% <ø> (ø) ⬆️
ScoutSuite/providers/aws/facade/facade.py 44% <ø> (-0.74%) ⬇️
...ite/providers/aws/resources/rds/parametergroups.py 35.71% <ø> (ø) ⬆️
ScoutSuite/providers/aws/facade/basefacade.py 75% <ø> (ø) ⬆️
...tSuite/providers/aws/resources/rds/subnetgroups.py 40% <ø> (-5.46%) ⬇️
ScoutSuite/providers/aws/resources/regions.py 38.09% <ø> (-2.82%) ⬇️
ScoutSuite/providers/aws/resources/s3/service.py 50% <ø> (-2.39%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7694eae...2d72e79. Read the comment docs.

@misg
Copy link
Contributor

misg commented Mar 30, 2019

In the end, this PR mainly aims to improve concurrent support for all the fetching done for AWS services. This is done mainly by refactoring the code so to use the new function get_and_set_concurrently that easily enable to fetch and set concurrently all attributes related to a specific kind of resource.

@Aboisier
Copy link
Contributor Author

Approved, @misg !

@misg misg changed the title Refactoring/resource configs todos Improve concurrent support for AWS services Mar 31, 2019
@misg misg merged commit f36c9d6 into refactoring/resource-configs Mar 31, 2019
Scout Suite automation moved this from In progress to Done Mar 31, 2019
@misg misg deleted the refactoring/resource-configs-todos branch March 31, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-provider-aws Affects AWS provider enhancement New feature or request providers-refactoring
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants