Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/94 ebs findings #303

Merged
merged 3 commits into from Apr 5, 2019
Merged

Feature/94 ebs findings #303

merged 3 commits into from Apr 5, 2019

Conversation

Aboisier
Copy link
Contributor

@Aboisier Aboisier commented Apr 4, 2019 •
edited

This is part of a PR on the proprietary repo: https://github.com/nccgroup/ScoutSuite-Proprietary/pull/126.

@Aboisier Aboisier self-assigned this Apr 4, 2019
@Aboisier Aboisier added component-findings Affects findings component-provider-aws Affects AWS provider and removed component-findings Affects findings labels Apr 4, 2019
@Aboisier Aboisier added this to In progress in Scout Suite via automation Apr 4, 2019
@Aboisier Aboisier added this to the Iteration #6 milestone Apr 4, 2019
Remi05
Remi05 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@Remi05 Remi05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

vifor2
vifor2 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 💯

@Aboisier Aboisier merged commit 80479d0 into develop Apr 5, 2019
Scout Suite automation moved this from In progress to Done Apr 5, 2019
@Aboisier Aboisier deleted the feature/94-ebs-findings branch April 5, 2019 12:03
@misg misg restored the feature/94-ebs-findings branch April 10, 2019 03:47
@codecov-io
Copy link

Codecov Report

Merging #303 into develop will decrease coverage by 0.03%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
- Coverage    35.29%   35.26%   -0.04%     
===========================================
  Files          176      176              
  Lines         5734     5742       +8     
===========================================
+ Hits          2024     2025       +1     
- Misses        3710     3717       +7
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/ec2.py 32% <11.11%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20866cd...5c3dd27. Read the comment docs.

@misg misg deleted the feature/94-ebs-findings branch April 10, 2019 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Remi05 Remi05 Remi05 approved these changes

@vifor2 vifor2 vifor2 approved these changes

@misg misg Awaiting requested review from misg

@x4v13r64 x4v13r64 Awaiting requested review from x4v13r64

@zer0x64 zer0x64 Awaiting requested review from zer0x64

Assignees

@Aboisier Aboisier

Labels
component-provider-aws Affects AWS provider
Projects
No open projects
Scout Suite
  
Done
Milestone
Iteration #6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Aboisier @codecov-io @Remi05 @vifor2