New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor file hierarchy #326
Conversation
@zer0x64 if this looks good to you I'll fix the tests [and merge] |
Just need to fix the tests, but it looks good! I'll test it today |
@zer0x64 fixed 😄 |
Codecov Report
@@ Coverage Diff @@
## develop #326 +/- ##
==========================================
+ Coverage 34.29% 34.3% +<.01%
==========================================
Files 179 179
Lines 5974 6040 +66
==========================================
+ Hits 2049 2072 +23
- Misses 3925 3968 +43
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed the command line tool from Scout
to scout
, but everything else seems fine and works when I try it!
Great 😄 What do you have to put when running through pip? |
I think it's still ScoutSuite? It would work like this:
|
Yep you're right, I've updated the README 😄 |
What this PR changes:
Scout.py
toscout.py
(PEP8)ScoutSuite/scout.py
toScoutSuite/__main__.py
main()
function fromScout.py
toScoutSuite/__main__.py
and rename it asrun_from_cli()
setup.py
to execute__main__:run_from_cli
The only thing I'm still a bit unhappy with is the uppercases in the module name (ScoutSuite) as it goes against PEP8 (https://www.python.org/dev/peps/pep-0008/#package-and-module-names), but changing it would be death.