Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Minor changes #333

Merged
merged 3 commits into from Apr 10, 2019
Merged

Refactor/Minor changes #333

merged 3 commits into from Apr 10, 2019

Conversation

x4v13r64
Copy link
Collaborator

A couple of minor changes:

  • Restored a few things that were missed during manual merge (including the report-name argument)
  • Finished moving global variables to ReportFile

@x4v13r64 x4v13r64 requested a review from vifor2 April 10, 2019 15:59
Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh... Very nice! 👍

@x4v13r64 x4v13r64 merged commit 3807842 into develop Apr 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #333 into develop will decrease coverage by 0.04%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #333      +/-   ##
===========================================
- Coverage    34.37%   34.33%   -0.05%     
===========================================
  Files          179      179              
  Lines         5960     5956       -4     
===========================================
- Hits          2049     2045       -4     
  Misses        3911     3911
Impacted Files Coverage Δ
ScoutSuite/__init__.py 100% <ø> (ø) ⬆️
ScoutSuite/core/cli_parser.py 10.66% <0%> (-2.5%) ⬇️
ScoutSuite/output/report_file.py 100% <100%> (ø) ⬆️
ScoutSuite/output/html.py 21.78% <50%> (ø) ⬆️
ScoutSuite/core/conditions.py 52.6% <50%> (+0.02%) ⬆️
ScoutSuite/output/js.py 25% <66.66%> (ø) ⬆️
ScoutSuite/output/result_encoder.py 23.4% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47cbe1c...b9271d6. Read the comment docs.

@Aboisier Aboisier deleted the refactor/manual-changes branch April 10, 2019 17:14
@zer0x64 zer0x64 restored the refactor/manual-changes branch April 13, 2019 20:53
@zer0x64 zer0x64 deleted the refactor/manual-changes branch April 13, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants