New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/elb policies revival #358
Conversation
@misg I think all you where missing was an HTTPS listener. I've configured one so you should now get results. |
Oh indeed, nice catch! I had a bug although, I just fixed it. I'm able to retrieve elb policies now, their names are correctly displayed in Scout Suite reports. But the fields |
Codecov Report
@@ Coverage Diff @@
## develop #358 +/- ##
===========================================
- Coverage 34.67% 34.52% -0.16%
===========================================
Files 187 188 +1
Lines 6166 6234 +68
===========================================
+ Hits 2138 2152 +14
- Misses 4028 4082 +54
Continue to review full report at Codecov.
|
…into refactoring/aws/elb
# Conflicts: # ScoutSuite/providers/aws/provider.py
@misg this should now be fixed, there was a minor bug in bringing back Scout2 code. |
This PR aims to bring back elb policies to life, as part of #298.
Although, I didn't manage to really test it (I tested it against our aws test account, with a load balancer set up but I didn't find a way for adding a name to my elb policy (which is not retrieved in the end for that reason)).
Could you take a look, @j4v ?