Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/elb policies revival #358

Merged
merged 12 commits into from Apr 18, 2019
Merged

Bugfix/elb policies revival #358

merged 12 commits into from Apr 18, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Apr 15, 2019

This PR aims to bring back elb policies to life, as part of #298.
Although, I didn't manage to really test it (I tested it against our aws test account, with a load balancer set up but I didn't find a way for adding a name to my elb policy (which is not retrieved in the end for that reason)).
Could you take a look, @j4v ?

@misg misg requested a review from x4v13r64 April 15, 2019 04:38
@misg misg added bugfix component-provider-aws Affects AWS provider labels Apr 15, 2019
@misg misg added this to In progress in Scout Suite via automation Apr 15, 2019
@x4v13r64
Copy link
Collaborator

@misg I think all you where missing was an HTTPS listener. I've configured one so you should now get results.

@misg
Copy link
Contributor Author

misg commented Apr 16, 2019

Oh indeed, nice catch! I had a bug although, I just fixed it. I'm able to retrieve elb policies now, their names are correctly displayed in Scout Suite reports. But the fields Protocols, Options and Ciphers are empty, not sure if it's expected or not (regarding the elb policy I use for testing), there could be some issue in the parsing/displaying.

@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #358 into develop will decrease coverage by 0.15%.
The diff coverage is 20.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
- Coverage    34.67%   34.52%   -0.16%     
===========================================
  Files          187      188       +1     
  Lines         6166     6234      +68     
===========================================
+ Hits          2138     2152      +14     
- Misses        4028     4082      +54
Impacted Files Coverage Δ
ScoutSuite/providers/base/services.py 25.71% <0%> (-1.56%) ⬇️
...uite/providers/aws/resources/elb/load_balancers.py 28.57% <0%> (ø) ⬆️
ScoutSuite/providers/base/configs/browser.py 52.3% <100%> (ø) ⬆️
ScoutSuite/providers/aws/resources/elb/base.py 87.5% <100%> (+1.78%) ⬆️
ScoutSuite/providers/aws/facade/elb.py 32.65% <20.83%> (-13.51%) ⬇️
ScoutSuite/providers/aws/resources/elb/policies.py 43.75% <43.75%> (ø)
ScoutSuite/providers/aws/provider.py 9.14% <6.45%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133e8b3...0d9f686. Read the comment docs.

@x4v13r64
Copy link
Collaborator

@misg this should now be fixed, there was a minor bug in bringing back Scout2 code.

@x4v13r64 x4v13r64 merged commit f776db8 into develop Apr 18, 2019
Scout Suite automation moved this from In progress to Done Apr 18, 2019
@x4v13r64 x4v13r64 deleted the refactoring/aws/elb branch April 29, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Scout Suite
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants