Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/AWS S3 versioning/MFA-delete findings #395 #420

Merged
merged 2 commits into from May 20, 2019

Conversation

x4v13r64
Copy link
Collaborator

Resolves #395 by:

  • Remove check for versioning for S3 MFA Delete finding
  • Improve rationales for versioning and MFA Delete findings

@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #420 into release/5.2.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/5.2.0     #420   +/-   ##
==============================================
  Coverage          34.43%   34.43%           
==============================================
  Files                192      192           
  Lines               6343     6343           
==============================================
  Hits                2184     2184           
  Misses              4159     4159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64cb5e2...e7c4416. Read the comment docs.

@x4v13r64 x4v13r64 merged commit f017f87 into release/5.2.0 May 20, 2019
@x4v13r64 x4v13r64 deleted the issues/395 branch May 20, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants