Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML finding description #441

Merged
merged 15 commits into from Jun 21, 2019
Merged

HTML finding description #441

merged 15 commits into from Jun 21, 2019

Conversation

x4v13r64
Copy link
Collaborator

@x4v13r64 x4v13r64 commented Jun 7, 2019

Implements #82.

TODO:

  • don't escape rationale content
  • add "Description" header to rationales~~ (only for issues with something more)~~
  • process CIS content in existing issues

Example rationale:

  "rationale": "Description:<br><br>Rotating Service Account keys will reduce the window of opportunity for an access key that is associated with a compromised or terminated account to be used. Service Account keys should be rotated to ensure that data cannot be accessed with an old key which might have been lost, cracked, or stolen. It should be ensured that keys are rotated every 90 days.<br><br>References:<ul><li>GCP CIS Benchmark v1.0.0 1.6</li</ul>",

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #441 into develop will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #441      +/-   ##
===========================================
- Coverage    34.36%   33.93%   -0.43%     
===========================================
  Files          197      198       +1     
  Lines         6455     6612     +157     
===========================================
+ Hits          2218     2244      +26     
- Misses        4237     4368     +131
Impacted Files Coverage Δ
ScoutSuite/providers/gcp/facade/kms.py 29.54% <0%> (-13.32%) ⬇️
ScoutSuite/__main__.py 15.15% <0%> (-4.85%) ⬇️
ScoutSuite/core/ruleset.py 75.57% <0%> (-2.3%) ⬇️
...utSuite/providers/azure/authentication_strategy.py 16.16% <0%> (-2.03%) ⬇️
ScoutSuite/core/cli_parser.py 11.39% <0%> (-0.45%) ⬇️
ScoutSuite/providers/gcp/resources/kms/keys.py 28% <0%> (ø)
ScoutSuite/providers/gcp/resources/kms/keyrings.py 44.82% <0%> (+7.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f8176...dffed35. Read the comment docs.

@x4v13r64 x4v13r64 merged commit 8c7f9c9 into develop Jun 21, 2019
@x4v13r64 x4v13r64 deleted the issues/82 branch June 21, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants