Enhancement/Azure Improvements (Storage Accounts & Security Centre) #505
Conversation
Added new rule in Securitycenter
# Conflicts: # ScoutSuite/providers/azure/resources/storageaccounts/base.py # ScoutSuite/providers/azure/rules/findings/storageaccount-default-network-access.json
| async def get_information_protection_policies(self): | ||
| try: | ||
| return await run_concurrently( | ||
| lambda: list(self._client.information_protection_policies.list()) |
There was a problem hiding this comment.
I'm getting a securitycenter.py L40: Failed to retrieve information protection policies: list() missing 1 required positional argument: 'scope' error.
There was a problem hiding this comment.
I don't have that error on my code. Maybe is fixed now, can you check please?
There was a problem hiding this comment.
Nope, and it's in the code https://github.com/Azure/azure-sdk-for-python/blob/ccd73c15088f969b8adaaf10f26faf00387405d8/sdk/security/azure-mgmt-security/azure/mgmt/security/operations/_information_protection_policies_operations.py#L170 so maybe you're not running latest version of the sdk?
There was a problem hiding this comment.
opened an issue - Azure/azure-sdk-for-python#7687
| @@ -206,6 +206,18 @@ | |||
| "enabled": true, | |||
| "level": "warning" | |||
| } | |||
| ], | |||
| "storageaccount-trusted-microsoft-services-enabled.json": [ | |||
There was a problem hiding this comment.
Looks like this rule is there twice?
There was a problem hiding this comment.
Ok this is now fixed. I think I mixed some code
|
Reviewed this PR and left some comments. Looks like there's some mixed code coming from #498, next time please be wary of this as it makes it harder to review changes! |
x4v13r64
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #505 +/- ##
==========================================
- Coverage 33.52% 33.5% -0.02%
==========================================
Files 270 273 +3
Lines 8177 8247 +70
==========================================
+ Hits 2741 2763 +22
- Misses 5436 5484 +48
Continue to review full report at Codecov.
|
|
Closing, code is now in #539. |
|
Closing, code is now in #539. |
No description provided.